Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sequence Matcher error in Bank Reconciliation #23539

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

marination
Copy link
Collaborator

Issue:

     File "/usr/lib64/python3.6/difflib.py", line 465, in get_matching_blocks
        if self.matching_blocks is not None:
    AttributeError: 'SequenceMatcher' object has no attribute 'matching_blocks'
  • SequenceMatcher accepts two strings along with a junk value criteria
  • If any of these input strings are None the error occurs. Empty strings work.

Fix:

  • Make sure None inputs are replaced by empty strings

@marination marination added the needs-tests This PR needs automated unit-tests. label Oct 8, 2020
@nabinhait nabinhait merged commit 758a68d into frappe:develop Oct 23, 2020
marination added a commit to marination/erpnext that referenced this pull request Nov 17, 2020
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
@marination marination removed old-backport version-12-hotfix needs-tests This PR needs automated unit-tests. labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants