Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Leave policy assignment #23112

Merged
merged 20 commits into from
Nov 25, 2020

Conversation

Anurag810
Copy link
Contributor

@Anurag810 Anurag810 commented Aug 21, 2020

Leave Policy Assignment

Screenshot 2020-08-20 at 6 50 19 PM
On granting leave

image

Grant Leaves in bulk

Screenshot 2020-08-20 at 6 50 01 PM

Bulk Leave policy Assignment

Screenshot 2020-08-20 at 4 45 36 PM

leave allocation Linking and validation for Leave policy assignment

Screenshot 2020-08-20 at 6 50 39 PM

Docs: frappe/erpnext_documentation#136

@Anurag810 Anurag810 changed the title Feat: Leave policy assignment feat(WIP): Leave policy assignment Aug 21, 2020
@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from 2b99b18 to 9158d64 Compare August 26, 2020 07:10
@Anurag810 Anurag810 changed the title feat(WIP): Leave policy assignment feat: Leave policy assignment Aug 26, 2020
@Anurag810 Anurag810 added needs-tests This PR needs automated unit-tests. needs-docs labels Aug 26, 2020
@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from 53bb95e to 3027f15 Compare August 28, 2020 08:00
@Anurag810 Anurag810 removed the needs-tests This PR needs automated unit-tests. label Aug 28, 2020
@Anurag810
Copy link
Contributor Author

@stale
Copy link

stale bot commented Oct 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 4, 2020
@stale stale bot closed this Oct 11, 2020
@Anurag810 Anurag810 reopened this Oct 13, 2020
@stale stale bot removed the inactive label Oct 13, 2020
@Anurag810
Copy link
Contributor Author

@nabinhait please check.

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflict

@nabinhait nabinhait added review-codacy CI-failing Unit tests or patch tests are failing. labels Oct 14, 2020
@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from 2867cf7 to 34c3f19 Compare October 15, 2020 09:13
@Anurag810
Copy link
Contributor Author

Please Check and test Patch. unsure of that.

Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix travis
  • Fix sider
  • Fix codacy
  • Add docs

@Anurag810
Copy link
Contributor Author

@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from e3b110c to 72f98bc Compare November 2, 2020 08:38
Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix sider issues

@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from c44aa38 to 95754f2 Compare November 24, 2020 12:29
@Anurag810 Anurag810 force-pushed the enhancements_for_leave_management branch from 95754f2 to 279d491 Compare November 24, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants