-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Issue form cleaned up and renamed Minutes to First Response field #23066
Conversation
erpnext/crm/report/first_response_time_for_opportunity/first_response_time_for_opportunity.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we need two reports on first response time? Could we instead have the doctype as an optional filter?
Since both of them belong to different modules(CRM and Support), I think it is better to keep them separate. |
I think we can have two reports but why duplicate the same 35 lines of code? |
Depends on: frappe/frappe#11302
Issue doctype
Before:
After:
Reports
Minutes to First Response for Issues -> First Response Time for Issues
Before:
After:
Minutes to First Response for Opportunity -> First Response Time for Opportunity