Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Issue form cleaned up and renamed Minutes to First Response field #23066

Merged
merged 11 commits into from
Sep 23, 2020

Conversation

ruchamahabal
Copy link
Member

Depends on: frappe/frappe#11302

  • Issue doctype

    • Renamed Fields
      • Service Level Agreement Fulfilled (agreement_fulfilled) -> Service Level Agreement Status (agreement_status)
      • Minutes to First Response (mins_to_first_response) -> First Response Time (first_response_time)
    • Changed Fieldtypes
      • Response by Variance: Float -> Duration
      • Resolution by Variance: Float -> Duration
      • Minutes to First Response: Float -> Duration

    Before:

    issue-form-before

    After:

    issue-after

    • Fields re-ordered
    • Service Level Agreement Details section is only visible if Track Service Level Agreement is enabled in Support Settings
  • Reports

    • Since "Minutes to First Response" has been renamed to "First Response Time", changed the related reports and updated desk pages
      • Minutes to First Response for Issues -> First Response Time for Issues

        Before:

        mins-issues

        After:

        first-response-time-issues

      • Minutes to First Response for Opportunity -> First Response Time for Opportunity

@harshit-30 harshit-30 removed the request for review from hrwX August 18, 2020 15:18
Copy link
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we need two reports on first response time? Could we instead have the doctype as an optional filter?

@ruchamahabal
Copy link
Member Author

Any reason why we need two reports on first response time? Could we instead have the doctype as an optional filter?

Since both of them belong to different modules(CRM and Support), I think it is better to keep them separate.

@barredterra
Copy link
Collaborator

barredterra commented Sep 11, 2020

I think we can have two reports but why duplicate the same 35 lines of code?

@nabinhait nabinhait self-assigned this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants