Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accounts): Add Condition Field In Pricing Rule #23014

Merged
merged 11 commits into from
Oct 8, 2020
Merged

feat(Accounts): Add Condition Field In Pricing Rule #23014

merged 11 commits into from
Oct 8, 2020

Conversation

abhishekbalam
Copy link
Contributor

@abhishekbalam abhishekbalam commented Aug 12, 2020

Condition field to add conditional expressions like in Assignment Rule:
territory == 'India' and order_type != 'Maintenance'

image

All fields available in the transaction (like Sales Invoice, Sales Order etc) are available
as their fieldnames directly for use in the conditions.

@deepeshgarg007 deepeshgarg007 self-assigned this Aug 12, 2020
@abhishekbalam
Copy link
Contributor Author

@rohitwaghchaure rohitwaghchaure added the needs-tests This PR needs automated unit-tests. label Aug 24, 2020
@stale
Copy link

stale bot commented Sep 27, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Sep 27, 2020
@abhishekbalam
Copy link
Contributor Author

Will write and push tests today itself.

@deepeshgarg007
Copy link
Member

@abhishekbalam any updates on this?

@abhishekbalam
Copy link
Contributor Author

@deepeshgarg007
Will do this asap, I'm having bandwidth issues.

@abhishekbalam
Copy link
Contributor Author

@rohitwaghchaure @deepeshgarg007

Test for condition field added.

image

@abhishekbalam abhishekbalam requested review from rohitwaghchaure and removed request for nextchamp-saqib October 1, 2020 09:27
@abhishekbalam
Copy link
Contributor Author

Hi, requesting review since this PR is open for too long:
@nabinhait @rohitwaghchaure @deepeshgarg007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants