Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: shopping cart #22617

Merged
merged 3 commits into from
Jul 23, 2020
Merged

refactor: shopping cart #22617

merged 3 commits into from
Jul 23, 2020

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Jul 8, 2020

Issue-

  • Cannot delete company because is linked with Shopping Cart Settings Even shopping cart is disabled.
  • Cart is not hidden from the navigation bar if the Shopping Cart is disabled.
  • 'Show configure button' in the Shopping Cart Settings is not self- explanatory.

Fixes-

  • Making Company and User Group not mandatory.
  • Making it mandatory depends on shopping cart enabled.
  • Hiding cart from navigation bar if the shopping cart is disabled.
  • Changing Show Configure Button -> Enable Variants.

Anurag810
Anurag810 previously requested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@Anurag810 Anurag810 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
have you changed as we talked earlier to remove white space?

@anupamvs anupamvs force-pushed the shopping-cart-issue-v13 branch from 00f6bac to a83406c Compare July 17, 2020 12:16
@anupamvs anupamvs force-pushed the shopping-cart-issue-v13 branch from a83406c to 3854f48 Compare July 17, 2020 12:24
@anupamvs anupamvs requested a review from Anurag810 July 17, 2020 12:24
@anupamvs anupamvs requested a review from marination July 20, 2020 14:49
@anupamvs anupamvs dismissed Anurag810’s stale review July 20, 2020 14:52

Done the changes!

@nabinhait nabinhait merged commit 7137b0b into develop Jul 23, 2020
@anupamvs anupamvs deleted the shopping-cart-issue-v13 branch July 23, 2020 11:48
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

@Anurag810 Anurag810 Awaiting requested review from Anurag810

@marination marination Awaiting requested review from marination

Assignees

@rohitwaghchaure rohitwaghchaure

@deepeshgarg007 deepeshgarg007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anupamvs @nabinhait @Anurag810 @rohitwaghchaure @deepeshgarg007