Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Quality Feedback and Template (minor) #22571

Merged
merged 1 commit into from
Jul 6, 2020
Merged

fix: Quality Feedback and Template (minor) #22571

merged 1 commit into from
Jul 6, 2020

Conversation

marination
Copy link
Collaborator

Issue:
image

Fixes:

  • Check if template field is populated before fetching template to populate table
  • Minor code cleanup
  • Change 'Name' to 'Feedback By' in Quality Feedback
  • Make Parameter table mandatory in Quality Feedback Template. Don't allow saving empty templates

@rohitwaghchaure rohitwaghchaure self-assigned this Jul 4, 2020
@rohitwaghchaure rohitwaghchaure merged commit 661bc46 into frappe:develop Jul 6, 2020
@marination
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed
    backport fail: repository is too big and no subscription is active

@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

Assignees

@rohitwaghchaure rohitwaghchaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marination @rohitwaghchaure