Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch project-related info in Timesheet (develop) #22423

Merged
merged 2 commits into from
Jul 9, 2020
Merged

fix: fetch project-related info in Timesheet (develop) #22423

merged 2 commits into from
Jul 9, 2020

Conversation

Alchez
Copy link
Contributor

@Alchez Alchez commented Jun 24, 2020

Changes:

  • On creating a new Timesheet from Task, the project and worked hours are pulled in the document as well
  • Remove redundant "View" buttons for Timesheet and Expense Claim since the dashboard is already available
  • Move add_fetch behaviour into JSON schema

@Alchez Alchez mentioned this pull request Jun 24, 2020
Merged
@marination marination self-assigned this Jun 24, 2020
@marination
Copy link
Collaborator

Please resolve conflicts

marination
marination previously approved these changes Jul 9, 2020
View reviewed changes
@marination marination merged commit cdf55ce into frappe:develop Jul 9, 2020
@marination marination mentioned this pull request Aug 27, 2020
Merged
@nabinhait nabinhait mentioned this pull request Apr 1, 2021
Merged
@Alchez Alchez deleted the dev-task-fetch-error branch March 2, 2022 11:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination marination approved these changes

@hrwX hrwX Awaiting requested review from hrwX

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees

@marination marination

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alchez @marination