fix: handle custom statuses for the pause SLA configuration #22349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Jun 22, 2020
|
@Mergifyio backport version-13-beta-pre-release |
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for two issues:
The response and resolution variables are unset on statuses configured for Hold and reset when the issue changes from a status configured for Hold to "Open" by adding the hold time. However, it should do so for any status which is not configured for hold otherwise the SLA fails for custom statuses as response and resolution variance fields are unset.
fix for code line: https://github.com/frappe/erpnext/blob/develop/erpnext/support/doctype/issue/issue.py#L104
The total hold time field should only be set if on_hold_since is captured and hold configurations are enabled in the SLA document.