fix: Set default reference Id for "On Previous Row Amount" and "On Previous Row Total" #22346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AfshanKhan
commented
Jun 19, 2020
•
- Added client side validation for "On Previous Row Amount" and "On Previous Row Total"
- On selecting "On Previous Row Amount" or "On Previous Row Total" in taxes table an error used to pop up in console which broke the script if reference row is not selected. And many times user is not aware that reference row field exists. So by default use previous row reference id
…able "tax", also replaced "-1" by "-2" as "idx" starts with 0 rather than 1
… and On Previous Row Total
deepeshgarg007
approved these changes
Jun 22, 2020
|
@Mergifyio backport version-12-hotfix |
|
Command
|
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.