Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to close (partially delivered) Subcontracting Order #38702

Closed
ophl55 opened this issue Dec 12, 2023 · 1 comment · Fixed by #39127
Closed

Option to close (partially delivered) Subcontracting Order #38702

ophl55 opened this issue Dec 12, 2023 · 1 comment · Fixed by #39127
Assignees

Comments

@ophl55
Copy link

ophl55 commented Dec 12, 2023

Is your feature request related to a problem? Please describe.
As a Purchase Order sometimes has to be closed manually the same applies to the Subcontrating Order.
For instance this might be the case when the order can or should not be delivered completly for any reason.
Currently you can close the PO. The SCO stays still open until completely delivered. The items are still shown as "to receive" in the reports and you can even submit further SCRs against the SCO.

Describe the solution you'd like
Close the SCO automatically in case the PO gets closed by the User. Also reopen it automatically in case the PO gets reopened by the user.

Describe alternatives you've considered
Add the option to close the SCO manually as it is done for the PO. Also add the option to reopen the SCO if closed.

Additional context
Minor error observed:
The status of the SCO is set to "Closed" by the code in a specific situation.

The status "Closed" is not defined for the SCO in the subcontracting_order.json. https://github.com/frappe/erpnext/blob/b562b4cf99e68108a0d7ba3a90e60ef3d7d01b0f/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.json#L373C4-L373C123

@ophl55
Copy link
Author

ophl55 commented Dec 12, 2023

@s-aga-r can you please check?

These are the same issues as described in the comments of your commit: b023e5d

@s-aga-r s-aga-r self-assigned this Dec 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants