Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove use of include directive from client side js #36407

Closed
ankush opened this issue Dec 14, 2021 · 1 comment
Closed

refactor: remove use of include directive from client side js #36407

ankush opened this issue Dec 14, 2021 · 1 comment

Comments

@ankush
Copy link
Member

ankush commented Dec 14, 2021 •
edited
Loading

remove use of inlcude directive like {% include 'some/js/file.js' %} because this makes js file not parsable by editors/linters etc. Better to load them separately.

solution:

  • replace include with frappe.require and move the JS files to public folder.
@ankush ankush self-assigned this Dec 14, 2021
@ankush ankush added this to the v14.0 milestone Jan 11, 2022
@ankush ankush removed this from the v14.0 milestone Jun 20, 2022
@ankush ankush removed their assignment Jul 5, 2022
@nabinhait nabinhait transferred this issue from frappe/erpnext Nov 24, 2022
@ankush ankush transferred this issue from frappe/frappe Jul 30, 2023
@ankush
Copy link
Member Author

ankush commented Jul 30, 2023

completed with this #36147

@ankush ankush closed this as completed Jul 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankush