Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System auto-suggest a batch with 0 quantity #30339

Closed
guilmori opened this issue Mar 21, 2022 · 1 comment · Fixed by #32788
Closed

System auto-suggest a batch with 0 quantity #30339

guilmori opened this issue Mar 21, 2022 · 1 comment · Fixed by #32788
Assignees
@s-aga-r
Labels
bug valid
Milestone
November 2022 Git...

Comments

@guilmori
Copy link

Information about bug

Why truncate decimals when validating batch qty ?

I need 0.4 kg, and the system select a batch with 0 qty.

erpnext/erpnext/stock/doctype/batch/batch.py

Line 262 in 01fd3ad

if cint(qty) <= cint(batch.qty):

Module

stock

Version

v13.16.0

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response
@guilmori guilmori added the bug label Mar 21, 2022
@ankush
Copy link
Member

ankush commented Mar 21, 2022 •
edited
Loading

makes sense. This should be flt and not cint. Can you send a PR?

@ankush ankush added the valid label Mar 21, 2022
@ankush ankush added this to the 13.24 milestone Mar 21, 2022
@s-aga-r s-aga-r mentioned this issue Nov 1, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@s-aga-r s-aga-r

Labels
bug valid
Projects
No open projects
Stock / Manufacturing ToDo
Status: Done
Milestone
November 2022 Github Issues
Development

Successfully merging a pull request may close this issue.

fix: use flt instead of cint in get_batch_no s-aga-r/erpnext
5 participants
@rohitwaghchaure @ankush @guilmori @deepeshgarg007 @s-aga-r