New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salary Slip useless validation message #28007

Closed

dj12djdjs opened this issue Oct 19, 2021 · 0 comments

Collaborator

dj12djdjs commented Oct 19, 2021

Why do we clear the employee right before displaying it in the error message?

erpnext/erpnext/payroll/doctype/salary_slip/salary_slip.py

Lines 174 to 176 in d11c215

    
           if ret_exist: 
        
           	self.employee = '' 
        
           	frappe.throw(_("Salary Slip of employee {0} already created for this period").format(self.employee))

dj12djdjs mentioned this issue

fix(payroll): Useless validation message in Salary Slip #28029

Merged

ruchamahabal closed this as completed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.