Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning on, then off "Homepage is Products" on the Products settings page does not revert back to Home Page #22733

Closed
dealproc opened this issue Jul 18, 2020 · 4 comments · Fixed by #22736

Comments

@dealproc
Copy link

By default, ERPNext provides a landing page for the main index of the site. If you activate "Home Page is Products" under the Products Settings section, save it, then deactivate the "Home Page is Products" value, the site still acts as-if the feature is enabled. The expected behavior of this is to revert back to the landing page style for the index page.

@Thunderbottom
Copy link
Contributor

I've made a fix for this. Please try and let me know if it works fine.

@dealproc
Copy link
Author

Thank you. Is this in the v12 branch, or where can I absorb it to test the functionality out?

@Thunderbottom
Copy link
Contributor

The fix is on the develop branch, you may test it out on that branch or wait for the backport to happen.

@dealproc
Copy link
Author

Thank you. I will wait for the backport, as I'm trying to determine how to deploy this into Azure.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants