Skip to content

Commit

Permalink
Merge pull request #33150 from frappe/mergify/bp/version-13-hotfix/pr…
Browse files Browse the repository at this point in the history
…-33144

fix: incorrect balance qty (backport #33144)
  • Loading branch information
rohitwaghchaure authored Nov 29, 2022
2 parents 99188af + cdb6a4e commit b08d36c
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def update_stock_ledger(self):

if item.has_serial_no or item.has_batch_no:
has_serial_no = True
self.get_sle_for_serialized_items(row, sl_entries)
self.get_sle_for_serialized_items(row, sl_entries, item)
else:
if row.serial_no or row.batch_no:
frappe.throw(
Expand Down Expand Up @@ -281,7 +281,7 @@ def update_stock_ledger(self):
if has_serial_no and sl_entries:
self.update_valuation_rate_for_serial_no()

def get_sle_for_serialized_items(self, row, sl_entries):
def get_sle_for_serialized_items(self, row, sl_entries, item):
from erpnext.stock.stock_ledger import get_previous_sle

serial_nos = get_serial_nos(row.serial_no)
Expand Down Expand Up @@ -347,6 +347,9 @@ def get_sle_for_serialized_items(self, row, sl_entries):
if row.qty:
args = self.get_sle_for_items(row)

if item.has_serial_no and item.has_batch_no:
args["qty_after_transaction"] = row.qty

args.update(
{
"actual_qty": row.qty,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,38 @@ def test_serial_no_creation_and_inactivation(self):
)
self.assertEqual(len(active_sr_no), 0)

def test_serial_no_batch_no_item(self):
item = self.make_item(
"Test Serial No Batch No Item",
{
"is_stock_item": 1,
"has_serial_no": 1,
"has_batch_no": 1,
"serial_no_series": "SRS9.####",
"batch_number_series": "BNS9.####",
"create_new_batch": 1,
},
)

warehouse = "_Test Warehouse - _TC"

sr = create_stock_reconciliation(
item_code=item.name,
warehouse=warehouse,
qty=1,
rate=100,
)

sl_entry = frappe.db.get_value(
"Stock Ledger Entry",
{"voucher_type": "Stock Reconciliation", "voucher_no": sr.name},
["actual_qty", "qty_after_transaction"],
as_dict=1,
)

self.assertEqual(flt(sl_entry.actual_qty), 1.0)
self.assertEqual(flt(sl_entry.qty_after_transaction), 1.0)


def create_batch_item_with_batch(item_name, batch_id):
batch_item_doc = create_item(item_name, is_stock_item=1)
Expand Down

0 comments on commit b08d36c

Please sign in to comment.