Skip to content

Commit

Permalink
fix: disposal_was_made_on_original_schedule_date
Browse files Browse the repository at this point in the history
  • Loading branch information
anandbaburajan committed Jan 30, 2023
1 parent 0902a5c commit 939a312
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 13 deletions.
7 changes: 1 addition & 6 deletions erpnext/assets/doctype/asset/asset.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from erpnext.assets.doctype.asset.depreciation import (
get_depreciation_accounts,
get_disposal_account_and_cost_center,
is_last_day_of_the_month,
)
from erpnext.assets.doctype.asset_category.asset_category import get_asset_category_account
from erpnext.controllers.accounts_controller import AccountsController
Expand Down Expand Up @@ -1078,12 +1079,6 @@ def get_total_days(date, frequency):
return date_diff(date, period_start_date)


def is_last_day_of_the_month(date):
last_day_of_the_month = get_last_day(date)

return getdate(last_day_of_the_month) == getdate(date)


@erpnext.allow_regional
def get_depreciation_amount(asset, depreciable_value, row):
if row.depreciation_method in ("Straight Line", "Manual"):
Expand Down
20 changes: 19 additions & 1 deletion erpnext/assets/doctype/asset/depreciation.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,16 @@

import frappe
from frappe import _
from frappe.utils import add_months, cint, flt, get_link_to_form, getdate, nowdate, today
from frappe.utils import (
add_months,
cint,
flt,
get_last_day,
get_link_to_form,
getdate,
nowdate,
today,
)
from frappe.utils.user import get_users_with_role

from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import (
Expand Down Expand Up @@ -372,6 +381,9 @@ def disposal_was_made_on_original_schedule_date(asset, schedule, row, posting_da
finance_book.depreciation_start_date, row * cint(finance_book.frequency_of_depreciation)
)

if is_last_day_of_the_month(finance_book.depreciation_start_date):
orginal_schedule_date = get_last_day(orginal_schedule_date)

if orginal_schedule_date == posting_date_of_disposal:
return True
return False
Expand Down Expand Up @@ -508,3 +520,9 @@ def get_disposal_account_and_cost_center(company):
frappe.throw(_("Please set 'Asset Depreciation Cost Center' in Company {0}").format(company))

return disposal_account, depreciation_cost_center


def is_last_day_of_the_month(date):
last_day_of_the_month = get_last_day(date)

return getdate(last_day_of_the_month) == getdate(date)
7 changes: 1 addition & 6 deletions erpnext/assets/doctype/asset/test_asset.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import make_purchase_invoice
from erpnext.assets.doctype.asset.asset import make_sales_invoice, update_maintenance_status
from erpnext.assets.doctype.asset.depreciation import (
is_last_day_of_the_month,
post_depreciation_entries,
restore_asset,
scrap_asset,
Expand Down Expand Up @@ -1529,9 +1530,3 @@ def set_depreciation_settings_in_company():

def enable_cwip_accounting(asset_category, enable=1):
frappe.db.set_value("Asset Category", asset_category, "enable_cwip_accounting", enable)


def is_last_day_of_the_month(dt):
last_day_of_the_month = get_last_day(dt)

return getdate(dt) == getdate(last_day_of_the_month)

0 comments on commit 939a312

Please sign in to comment.