Skip to content

Commit

Permalink
fix: check for duplicate pos invoices in closing entry
Browse files Browse the repository at this point in the history
  • Loading branch information
ruthra-kumar committed Feb 17, 2023
1 parent a0eb5e5 commit 890c8a0
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,24 @@ def validate(self):
if frappe.db.get_value("POS Opening Entry", self.pos_opening_entry, "status") != "Open":
frappe.throw(_("Selected POS Opening Entry should be open."), title=_("Invalid Opening Entry"))

self.validate_duplicate_pos_invoices()
self.validate_pos_invoices()

def validate_duplicate_pos_invoices(self):
pos_occurences = {}
for idx, inv in enumerate(self.pos_transactions, 1):
pos_occurences.setdefault(inv.pos_invoice, []).append(idx)

error_list = []
for key, value in pos_occurences.items():
if len(value) > 1:
error_list.append(
_("{} is added multiple times on rows: {}".format(frappe.bold(key), frappe.bold(value)))
)

if error_list:
frappe.throw(error_list, title=_("Duplicate POS Invoices found"), as_list=True)

def validate_pos_invoices(self):
invalid_rows = []
for d in self.pos_transactions:
Expand Down

0 comments on commit 890c8a0

Please sign in to comment.