Skip to content

Commit

Permalink
Merge pull request #34018 from s-aga-r/fix-so-on-hold
Browse files Browse the repository at this point in the history
fix: update `reserved_qty` when `Sales Order` marked as `Hold`
  • Loading branch information
s-aga-r authored Feb 14, 2023
2 parents 9600858 + 4473107 commit 75d9dbc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions erpnext/stock/stock_balance.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def get_reserved_qty(item_code, warehouse):
and parenttype='Sales Order'
and item_code != parent_item
and exists (select * from `tabSales Order` so
where name = dnpi_in.parent and docstatus = 1 and status != 'Closed')
where name = dnpi_in.parent and docstatus = 1 and status not in ('On Hold', 'Closed'))
) dnpi)
union
(select stock_qty as dnpi_qty, qty as so_item_qty,
Expand All @@ -131,7 +131,7 @@ def get_reserved_qty(item_code, warehouse):
and (so_item.delivered_by_supplier is null or so_item.delivered_by_supplier = 0)
and exists(select * from `tabSales Order` so
where so.name = so_item.parent and so.docstatus = 1
and so.status != 'Closed'))
and so.status not in ('On Hold', 'Closed')))
) tab
where
so_item_qty >= so_item_delivered_qty
Expand Down

0 comments on commit 75d9dbc

Please sign in to comment.