Skip to content

Commit

Permalink
fix: get consumed_qty based on received_qty in SCR
Browse files Browse the repository at this point in the history
  • Loading branch information
s-aga-r committed Nov 6, 2022
1 parent c447dfa commit 70c9b8d
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions erpnext/controllers/subcontracting_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __get_data_before_save(self):
and self._doc_before_save
):
for row in self._doc_before_save.get("items"):
item_dict[row.name] = (row.item_code, row.qty)
item_dict[row.name] = (row.item_code, row.received_qty or row.qty)

return item_dict

Expand All @@ -118,7 +118,9 @@ def __identify_change_in_item_table(self):

for row in self.items:
self.__reference_name.append(row.name)
if (row.name not in item_dict) or (row.item_code, row.qty) != item_dict[row.name]:
if (row.name not in item_dict) or (row.item_code, row.received_qty or row.qty) != item_dict[
row.name
]:
self.__changed_name.append(row.name)

if item_dict.get(row.name):
Expand Down Expand Up @@ -461,12 +463,13 @@ def __add_supplied_item(self, item_row, bom_item, qty):

def __get_qty_based_on_material_transfer(self, item_row, transfer_item):
key = (item_row.item_code, item_row.get(self.subcontract_data.order_field))
item_qty = item_row.received_qty or item_row.qty

if self.qty_to_be_received == item_row.qty:
if self.qty_to_be_received.get(key) == item_qty:
return transfer_item.qty

if self.qty_to_be_received:
qty = (flt(item_row.qty) * flt(transfer_item.qty)) / flt(self.qty_to_be_received.get(key, 0))
qty = (flt(item_qty) * flt(transfer_item.qty)) / flt(self.qty_to_be_received.get(key, 0))
transfer_item.item_details.required_qty = transfer_item.qty

if transfer_item.serial_no or frappe.get_cached_value(
Expand All @@ -491,7 +494,11 @@ def __set_supplied_items(self):
for bom_item in self.__get_materials_from_bom(
row.item_code, row.bom, row.get("include_exploded_items")
):
qty = flt(bom_item.qty_consumed_per_unit) * flt(row.qty) * row.conversion_factor
qty = (
flt(bom_item.qty_consumed_per_unit)
* flt(row.received_qty or row.qty)
* row.conversion_factor
)
bom_item.main_item_code = row.item_code
self.__update_reserve_warehouse(bom_item, row)
self.__set_alternative_item(bom_item)
Expand Down

0 comments on commit 70c9b8d

Please sign in to comment.