From 3dd119eeea77313955d23a474b7321e1c5d83676 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Mon, 24 Jul 2023 14:50:11 +0530 Subject: [PATCH] refactor: apply terms based validation only on sales/purchase doctyp --- erpnext/accounts/doctype/payment_entry/payment_entry.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.py b/erpnext/accounts/doctype/payment_entry/payment_entry.py index c175e2475d22..596881a4e07d 100644 --- a/erpnext/accounts/doctype/payment_entry/payment_entry.py +++ b/erpnext/accounts/doctype/payment_entry/payment_entry.py @@ -210,7 +210,11 @@ def validate_allocated_amount(self): def term_based_allocation_enabled_for_reference( self, reference_doctype: str, reference_name: str ) -> bool: - if reference_doctype and reference_name: + if ( + reference_doctype + and reference_doctype in ["Sales Invoice", "Sales Order", "Purchase Order", "Purchase Invoice"] + and reference_name + ): if template := frappe.db.get_value(reference_doctype, reference_name, "payment_terms_template"): return frappe.db.get_value( "Payment Terms Template", template, "allocate_payment_based_on_payment_terms"