From 3bceb475427ed13fc2cf57ebe8c6adfc8820fa57 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 29 Dec 2022 09:33:59 +0530 Subject: [PATCH] fix(pricing rule): consider child tables in condition (backport #33469) (#33470) fix(pricing rule): consider child tables in condition (#33469) (cherry picked from commit cabaed9ed2526e2649d173c806f6987d3377b0c3) Co-authored-by: Dany Robert --- erpnext/accounts/doctype/pricing_rule/utils.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/accounts/doctype/pricing_rule/utils.py b/erpnext/accounts/doctype/pricing_rule/utils.py index ab1d7385f786..199766e9a8df 100644 --- a/erpnext/accounts/doctype/pricing_rule/utils.py +++ b/erpnext/accounts/doctype/pricing_rule/utils.py @@ -246,10 +246,15 @@ def get_other_conditions(conditions, values, args): if args.get("doctype") in [ "Quotation", + "Quotation Item", "Sales Order", + "Sales Order Item", "Delivery Note", + "Delivery Note Item", "Sales Invoice", + "Sales Invoice Item", "POS Invoice", + "POS Invoice Item", ]: conditions += """ and ifnull(`tabPricing Rule`.selling, 0) = 1""" else: