fix: only group similar items in print format if group_same_items is …

…checked in pick list (backport #33627) (#33630)

fix: only group similar items in print format if group_same_items is checked in pick list (#33627)

* fix: only group similar items if group same items is checked in pick list

* test: non grouping of locations if group_same_items is false

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit cfb0bb1)

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>

erpnext/stock/doctype/pick_list/pick_list.py

@@ -230,7 +230,8 @@ def validate_for_qty(self):
 			frappe.throw(_("Qty of Finished Goods Item should be greater than 0."))
 
 	def before_print(self, settings=None):
-		self.group_similar_items()
+		if self.group_same_items:
+			self.group_similar_items()
 
 	def group_similar_items(self):
 		group_item_qty = defaultdict(float)

erpnext/stock/doctype/pick_list/test_pick_list.py

@@ -445,6 +445,20 @@ def _compare_dicts(a, b):
 		pl.before_print()
 		self.assertEqual(len(pl.locations), 4)
 
+		# grouping should not happen if group_same_items is False
+		pl = frappe.get_doc(
+			doctype="Pick List",
+			group_same_items=False,
+			locations=[
+				_dict(item_code="A", warehouse="X", qty=5, picked_qty=1),
+				_dict(item_code="B", warehouse="Y", qty=4, picked_qty=2),
+				_dict(item_code="A", warehouse="X", qty=3, picked_qty=2),
+				_dict(item_code="B", warehouse="Y", qty=2, picked_qty=2),
+			],
+		)
+		pl.before_print()
+		self.assertEqual(len(pl.locations), 4)
+
 		# grouping should halve the number of items
 		pl = frappe.get_doc(
 			doctype="Pick List",