Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm.addr should not log the private key #6696

Closed
aviggiano opened this issue Jan 2, 2024 · 0 comments · Fixed by #6698
Closed

vm.addr should not log the private key #6696

aviggiano opened this issue Jan 2, 2024 · 0 comments · Fixed by #6698
Labels
T-feature Type: feature

Comments

@aviggiano
Copy link

Component

Forge

Describe the feature you would like

Currently, vm.deriveKey omits the pk parameter:

    ├─ [0] VM::deriveKey(<pk>) [staticcall]
    │   └─ ← <pk>

However, vm.addr does not:

    ├─ [0] VM::addr(77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]) [staticcall]
    │   └─ ← 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266

Ideally, both would omit the private key in order to prevent potential mistakes and loss of funds by developers.

Additional context

No response

@aviggiano aviggiano added the T-feature Type: feature label Jan 2, 2024
@gakonst gakonst added this to Foundry Jan 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant