Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--buffer flag for forge script to adjust broadcast buffer size #6669

Closed
chlwys opened this issue Dec 26, 2023 · 4 comments
Closed

--buffer flag for forge script to adjust broadcast buffer size #6669

chlwys opened this issue Dec 26, 2023 · 4 comments
Labels
Cmd-forge-script Command: forge script D-easy Difficulty: easy T-feature Type: feature

Comments

@chlwys
Copy link

chlwys commented Dec 26, 2023

Component

Forge

Describe the feature you would like

add a --buffer flag for forge script to adjust broadcast buffer size – transactions are broadcasted in hardcoded batches of 100, introduced in #1824. This is fine for most chains, but is still too big for some (eg Optimism Sepolia).

--slow works, but can be excruciatingly slow with big scripts. Proposing --buffer as an optional flag (defaults to 100) that customises this broadcast buffer size. This would enable somewhere between --slow and buffer=100 and bigger buffer sizes for chains that support it

Additional context

working on a large testnet deployment on Optimism Sepolia (~2000 txes) and getting rate limited very quickly. Running a personal archive node, tracked down the issue to the central sequencer rate limiting after sending about 20-30 transactions at once

--slow takes over 12h to run this script TT

@chlwys chlwys added the T-feature Type: feature label Dec 26, 2023
@gakonst gakonst added this to Foundry Dec 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 26, 2023
@DaniPopes
Copy link
Member

Sounds reasonable, wdyt @Evalir @mattsse

@Evalir
Copy link
Member

Evalir commented Jan 30, 2024

Yeah I think this is a good idea. We've seen similar complaints about the batch size a few months ago, doesn't hurt to add it

@Evalir Evalir added D-easy Difficulty: easy Cmd-forge-script Command: forge script labels Jan 30, 2024
@chlwys
Copy link
Author

chlwys commented Feb 14, 2024

<3

@DaniPopes
Copy link
Member

Implemented as --batch-size in #7540

@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-script Command: forge script D-easy Difficulty: easy T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

3 participants