Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and dedupe ethers-rs vendored code #6104

Closed
Evalir opened this issue Oct 25, 2023 · 1 comment
Closed

Remove and dedupe ethers-rs vendored code #6104

Evalir opened this issue Oct 25, 2023 · 1 comment
Assignees
Labels
P-high Priority: high T-debt Type: code debt
Milestone

Comments

@Evalir
Copy link
Member

Evalir commented Oct 25, 2023

Some code got vendored on #5986 to decouple types from ethers. Namely:

  • Numeric type to parse different types of numbers (percentages, decimals, hex strings): These should either be deduped into a single Numeric type we can use everywhere and either upstream to alloy or centralize in common.
  • format_units: This utility should eventually be upstreamed to Alloy primitives due to its usefulness.
@Evalir Evalir added P-high Priority: high T-debt Type: code debt labels Oct 25, 2023
@Evalir Evalir added this to the v1.0.0 milestone Oct 25, 2023
@gakonst gakonst added this to Foundry Oct 25, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 25, 2023
@Evalir Evalir mentioned this issue Oct 25, 2023
43 tasks
@Evalir Evalir self-assigned this Nov 2, 2023
@Evalir
Copy link
Member Author

Evalir commented Dec 14, 2023

Closing—this was recently removed and added to alloy

@Evalir Evalir closed this as completed Dec 14, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high Priority: high T-debt Type: code debt
Projects
Archived in project
Development

No branches or pull requests

1 participant