Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Migrate Executor to SolCall and define calls ahead of time #6098

Closed
Evalir opened this issue Oct 24, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@Evalir
Copy link
Member

Evalir commented Oct 24, 2023

With #5986 we'll be moving to a dynamic encoder executor, but we should move to using alloy-sol-type's SolCall, and define the calls ahead of time with sol!. This is fine, as we only need the typed return data when we know the function we're calling ahead of time—in other ocassions, we just use the RawCallResult and handle the bytes.

@gakonst gakonst added this to Foundry Oct 24, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 24, 2023
@Evalir Evalir added this to the v1.0.0 milestone Oct 24, 2023
@Evalir Evalir mentioned this issue Oct 25, 2023
43 tasks
@DaniPopes DaniPopes self-assigned this Oct 25, 2023
@DaniPopes
Copy link
Member

This is actually counter-productive because we need to handle both dynamic and static encoder this way

@DaniPopes DaniPopes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants