Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing running forge test on a node over rpc. #5024

Closed
itsdevbear opened this issue May 24, 2023 · 2 comments
Closed

Allowing running forge test on a node over rpc. #5024

itsdevbear opened this issue May 24, 2023 · 2 comments
Labels
T-feature Type: feature

Comments

@itsdevbear
Copy link

Component

Forge

Describe the feature you would like

Right now running forge test forces using the the built in revm to run the tests against. This is great, but if someone is trying to test smart contract logic that interacts with a custom precompile or some modified version of the EVM it prevents this.

For instance, we want to run unit tests that utilize precompile contracts in https://github.com/berachain/polaris and we cannot do so other than jankily writing a forge script.

Additional context

No response

@itsdevbear itsdevbear added the T-feature Type: feature label May 24, 2023
@gakonst gakonst added this to Foundry May 24, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry May 24, 2023
@onbjerg
Copy link
Collaborator

onbjerg commented May 24, 2023

Ref #1505 and #1078 and bluealloy/revm#280

Running forge test over RPC is counter-intuitive since we would not have any of the hooks necessary to insert cheatcodes or do tracing. It would be a lot of work for marginal benefit at best vs. adding support for custom precompiles which has better longetivity

@zerosnacks
Copy link
Member

Marking as not planned given reasons raised and work on supporting custom precompiles has significantly progressed

See: #7498 + https://book.getfoundry.sh/cheatcodes/etch#using-vmetch-for-enabling-custom-precompiles

@zerosnacks zerosnacks closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

3 participants