-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(script): tracking issue for script improvements #4444
Comments
Based on our experience in making multiple deployments in December 2022, a big takeaway was that the transaction lifecycle management needed rework. Due to unreliable RPC providers and network issues, the foundry script should be more robust in handling these issues and issuing the proper transactions in the appropriate order. Relevant issues are being discussed afaik in the The TL;DR is that the forge script should be more robust and recover from more failures without the user resorting to multiple |
Why not just let users submit bundles instead of individual transactions? That removes a lot of issues. No need to recover if atomic. |
I agree that would be a nice feature, but it only helps on mainnet when the total bundle uses <30M gas, so it doesn’t solve the problem for all users and all chains |
Ethereum mainnet is the relevant chain. Supporting submission via bundles can be adopted downstream by other chains. Transaction submission bundling isn't about gas usage per se, it's about atomic deployment. The case about other users and other chains is irrelevant, as it does not worsen their situation. |
roughly prioritized/sorted, still a work in progress
High Priority
These are high priority because they block deployment, and user's need to find workarounds or user other tools as a result
exceeds block gas limit
error onforge script
deployment #3294Library Issues
forge script
): libraries that are used in a deployment are deployed even if their use isn't within avm.start/stopBroadcast
#3295Ledger Issues
Other
These are not yet sorted
forge script
): add ability to replay failed transaction on a local anvil fork #2673CALLER
balance asU256::MAX
#2390 (specifically this comment)forge script
was successful atomicallyvm.confirmContinue
cheat code #2399 (comment)forge script --watch
is not watching anything #4476 (comment)forge script
in parallel #2884The text was updated successfully, but these errors were encountered: