Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let deployment scripts support some kind of convenient deployment tracking/export facilities like hardhat-deploy #2550

Closed
Gilgames000 opened this issue Aug 2, 2022 · 6 comments
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature

Comments

@Gilgames000
Copy link

Component

Forge

Describe the feature you would like

Hi! It would be cool if forge deployment scripts supported some kind of convenient deployment tracking/export facilities like hardhat-deploy's export functionality.

As of now, the data/state is already being tracked in out/ and broadcast/ indeed! But it's all scattered around. What hardhat-deploy's export does is aggregate the essential deployment data, for a specific chain or for all, into a single file. You can then just drop this json file in your web app and have access to all the deployed contracts' ABI and addresses on the specified chains. It's just kinda handy and easier to automate updates.

Additional context

No response

@Gilgames000 Gilgames000 added the T-feature Type: feature label Aug 2, 2022
@gakonst gakonst added this to Foundry Aug 2, 2022
@gakonst gakonst moved this to Todo in Foundry Aug 2, 2022
@tynes
Copy link
Contributor

tynes commented Aug 2, 2022

I was thinking of implementing this as part of https://github.com/foundry-rs/hardhat

A hardhat task that wraps forge script and then it would generate the hardhat deploy style artifacts. The idea is to make it easy to migrate from hardhat deploy to forge script

@ind-igo
Copy link
Contributor

ind-igo commented Aug 2, 2022

Would be awesome! I wrote this discussion post months ago but got busy with work obligations. I am a rust noob but would love to help where possible. #114

@onbjerg onbjerg added C-forge Command: forge Cmd-forge-script Command: forge script labels Aug 3, 2022
@PierrickGT
Copy link
Contributor

I was thinking of implementing this as part of https://github.com/foundry-rs/hardhat

A hardhat task that wraps forge script and then it would generate the hardhat deploy style artifacts. The idea is to make it easy to migrate from hardhat deploy to forge script

@tynes are you still working on implementing this feature? It would indeed be super useful!

@tynes
Copy link
Contributor

tynes commented Jan 19, 2023

No, i've decided that its not the ideal approach and instead opened this issue #3911

Would rather have a higher level deploy command built into forge itself instead of hacking the hh plugin to work

@mds1
Copy link
Collaborator

mds1 commented Apr 11, 2023

Any objections to closing this in favor of #3911 as the canonical issue to spec out some higher-level functionality over forge script? I think one issue to discuss such a feature makes it easier to keep track of things

@mds1
Copy link
Collaborator

mds1 commented Apr 13, 2023

Optimistically closing in favor of #3911 and #4732

@mds1 mds1 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

6 participants