Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast mktx / sign transactions without broadcasting #1273

Closed
saucepoint opened this issue Apr 12, 2022 · 6 comments · Fixed by #7056
Closed

cast mktx / sign transactions without broadcasting #1273

saucepoint opened this issue Apr 12, 2022 · 6 comments · Fixed by #7056
Assignees
Labels
C-cast Command: cast D-easy Difficulty: easy first issue A good way to start contributing P-low Priority: low T-feature Type: feature

Comments

@saucepoint
Copy link

Component

Cast

Describe the feature you would like

It would be nice if cast can sign and prepare transactions without broadcasting them.

This will be especially useful for hardware wallets where a signed transaction is created (via hardware device prompts) and the transaction is broadcasted at a later time

Additional context

seth mktx returns a raw hash which can be used with seth publish (and cast publish)

https://github.com/dapphub/dapptools/tree/master/src/seth#seth-mktx

@saucepoint saucepoint added the T-feature Type: feature label Apr 12, 2022
@onbjerg onbjerg added the C-cast Command: cast label Apr 12, 2022
@onbjerg
Copy link
Collaborator

onbjerg commented Apr 12, 2022

Ref #1060

@onbjerg onbjerg added first issue A good way to start contributing P-low Priority: low D-easy Difficulty: easy labels Apr 12, 2022
@saucepoint
Copy link
Author

@onbjerg you can assign me the issue, i'll have an honest attempt at it over the next few days

@sambacha
Copy link
Contributor

Ref #1060

These are similar issues, except my issue is only asking for cast to provide the transaction details and leave the rest to the external wallet provider.

Fwiw most wallets do not allow you to return the signed transaction. They immediately broadcast it. You will most likely have to rely on eth_sign to get that functionality

@onbjerg
Copy link
Collaborator

onbjerg commented Apr 13, 2022

@sambacha I'm not sure I understand #1060 then, I've left a comment.

@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@onbjerg onbjerg moved this from Todo to In Progress in Foundry Apr 17, 2022
@sambacha
Copy link
Contributor

sambacha commented May 9, 2022

@sambacha I'm not sure I understand #1060 then, I've left a comment.

This is working for cast, but not for forge

@yaroslavyaroslav
Copy link

Are we there yet, Shrek?

There's just cast is actually unusable in Polygon, since there's only sendRaw method provided. And there's nothing to put in publish method.

@ay ay mentioned this issue Feb 9, 2024
@jenpaff jenpaff moved this from In Progress to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast D-easy Difficulty: easy first issue A good way to start contributing P-low Priority: low T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants