Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Stubs depend on javaType. #1516

Open
mcarcaso opened this issue Aug 24, 2018 · 1 comment
Open

JS Stubs depend on javaType. #1516

mcarcaso opened this issue Aug 24, 2018 · 1 comment

Comments

@mcarcaso
Copy link
Contributor

This line here makes stripping the javaType property from foam.core.Arguments impossible:
https://github.com/foam-framework/foam2/blob/master/src/lib/Stub.js#L21

@adamvy
Copy link
Contributor

adamvy commented Aug 24, 2018

I don't think we every want to serialize contexts, so if we have a foam.typeOf() for Context then we should just be able to always null them out as arguments.

I also think we should add contextOriented: true to Method so we can better detect this (it would also clean up some hacks in the java Skeleton code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants