Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding leuven-theme to GNU ELPA #96

Open
skangas opened this issue Aug 18, 2022 · 6 comments
Open

Adding leuven-theme to GNU ELPA #96

skangas opened this issue Aug 18, 2022 · 6 comments

Comments

@skangas
Copy link
Contributor

skangas commented Aug 18, 2022

leuven-theme.el is shipped with Emacs, but it would be nice if users could get upgrades through GNU ELPA. It should be easy to add it, if we agree that it's a good idea.

Fabrice, what do you think?

@fniessen
Copy link
Owner

Dear @skangas , are you explicitly making a difference between MELPA and ELPA? Because it's already on MELPA... and via Git... so, in fact, you do have 3 versions - the last 2 ones with the same lifecycle, though...

@skangas
Copy link
Contributor Author

skangas commented Aug 18, 2022

Yes, they are different archives. GNU ELPA is configured in Emacs by default, whereas MELPA is not.

(Note that ELPA properly refers only to the protocol that is used by both GNU ELPA and MELPA.)

@fniessen
Copy link
Owner

As there are already 2 places (MELPA and Git) to get a recent copy, I don't intend, by lack of time, to invest time for looking at how to make it available on ELPA.
Would you have time, and wish that feature, that'd be welcomed though.

@skangas
Copy link
Contributor Author

skangas commented Sep 21, 2022

On current master, we have this MELPA-inspired version in leuven.el:

;; Version: 20200513.1928

On GNU ELPA, we do not follow the versioning scheme; all packages have versions like, e.g. "0.1". Do you think we could change the versioning scheme of leuven.el to make it fit in better with the rest of the packages (and indeed with Emacs itself)?

If the answer is yes, I'm happy to add it to GNU ELPA.

PS. BTW, maybe it's worth updating the version of leuven.el that is on the emacs-28 branch in any case?

@fniessen
Copy link
Owner

fniessen commented Sep 22, 2022

Dear @skangas ,

Yes, we could change the naming conventions for the versions - no worry - to be put in GNU ELPA.
Yes, also, the current version of leuven.el could be made part of emacs-28.

Are you planning to do (both of) this?

@skangas
Copy link
Contributor Author

skangas commented Sep 22, 2022

Hi @fniessen,

Sure, I can add a pull request with the new version number. Do you have any preferences for where to start, or does 1.0 sound good to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants