-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple "hello fmt" project which tests the compiler flags #970
Comments
In our huge code base at ${BIG_CO}, each of these flags would have pinpointed bug locations. Yes, some of them are very noisy. But we're working through getting them cleaned up, one dozen at a time. |
We do the same in our $(SMALL_CO). We find real bugs by doing so. |
Most of these warnings are already there: https://github.com/fmtlib/fmt/blob/master/CMakeLists.txt#L70 . PRs to enable and at the same time fix additional warnings (within reason, |
Opened #983 . We are close to enabling -Wsign-conversion warnings (interestingly enough it is not part of -Wconversion on GCC but it is part of -Wconversion on Clang). |
Fixed by #989, thanks! |
There seem to be an ebb and flow of regressions when building with stricter compilation flags. I suggest adding a simple "hello fmt" project that is built using the following flags for GCC and Clang:
-Wall -Wextra -Werror -pedantic -Wconversion -Wsign-conversion -Wunused -Wshadow -Wdouble-promotion -Wcast-align -Wnull-dereference
With this small project the automated builders could catch the build breaks.
The text was updated successfully, but these errors were encountered: