Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffered_file::operator=(buffered_file&& other) is annotated as FMT_NOEXCEPT but calls close #1422

Closed
0x8000-0000 opened this issue Nov 26, 2019 · 2 comments
Closed

buffered_file::operator=(buffered_file&& other) is annotated as FMT_NOEXCEPT but calls close #1422

0x8000-0000 opened this issue Nov 26, 2019 · 2 comments

Comments

@0x8000-0000
Copy link
Contributor

fmt/include/fmt/posix.h

Line 161 in 4afb39b

close();

buffered_file::operator=(buffered_file&& other) is annotated as FMT_NOEXCEPT but calls close, which rightly is not annotated as FMT_NOEXCEPT because it throws .
@0x8000-0000
Copy link
Contributor Author

Found with cppcheck 1.89

@0x8000-0000
Copy link
Contributor Author

Introduced in bb0c8bf

@0x8000-0000 0x8000-0000 mentioned this issue Nov 27, 2019
Merged
@vitaut vitaut closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @0x8000-0000