-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Wpedantic: ISO C++ did not adopt string literal operator templates taking an argument pack of characters #1267
Comments
Or we could locally disable the warning; that is what I usually do. |
@foonathan I don't think it is the right solution as it is important to comply to this standard as stated:
https://stackoverflow.com/questions/2855121/what-is-the-purpose-of-using-pedantic-in-gcc-g-compiler |
I meant something like this:
That disables the diagnostic for this piece of code. You can still use -pedantic, it just won't complain about it. |
@eao197 Do you think that it would that mean that RESTinio should patch this on the libfmt include in the chain call origin of |
@binarytrails |
UDL templates were supposed to be disabled by default on GCC 9 and later: a6e8ed1, but it looks that version check is incorrect. A PR is welcome. |
@eao197 Sure thing! Thank you for looking into it.
Thank you all for the feedback and help! It is highly appreciated :) |
Actually, with the current version check UDL templates should already be disabled on GCC 9.1. |
@vitaut but the error is there in fmt with gcc 9.1... |
@binarytrails, the error message suggests that it's {fmt} 5.3. Does it happen on master? |
@vitaut I wish I reached that point in compiling but using master branch gave a bunch of other errors seen below. ofc, do you know when is the next fmt release?
|
This doesn't look like |
Is the fix to remove the <-pedantic> flag from the Cmake/build scripts? |
You can define the Lines 151 to 163 in 2797588
|
Hello!
I manged to fix the below error by providing the
CXXFLAGS+=" -DFMT_USE_USER_DEFINED_LITERALS=0"
in Autotools build of OpenDHT who has a dependency of libfmt from now on.However, I think it would be better to put this flag to false by default to avoid specifying this flag in each project trying to use a new version of fmt along with
-Wpedantic
standard flag!Cheers,
Seva
References: https://github.com/citra-emu/citra/issues/4766, Stiffstream/restinio#45.
The text was updated successfully, but these errors were encountered: