Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error under MSVC due to unsupported #warning directive. #1143

Closed
rcane opened this issue May 5, 2019 · 1 comment
Closed

Compile error under MSVC due to unsupported #warning directive. #1143

rcane opened this issue May 5, 2019 · 1 comment

Comments

@rcane
Copy link
Contributor

rcane commented May 5, 2019

The #warning directive in time.h is not recognized by MSVC and therefor produces a compile error.

We could use #pragma message("fmt/time.h is deprecated...") under MSVC instead to at least get the message output.
@vitaut
Copy link
Contributor

vitaut commented May 5, 2019

We could use #pragma message("fmt/time.h is deprecated...") under MSVC instead to at least get the message output.

Seems reasonable. Could you submit a PR?

@rcane rcane mentioned this issue May 5, 2019
Merged
@vitaut vitaut closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @rcane