Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellVoyager Z adjustment: support simultaneous acquisition #127

Closed
imagejan opened this issue May 6, 2024 · 1 comment
Closed

CellVoyager Z adjustment: support simultaneous acquisition #127

imagejan opened this issue May 6, 2024 · 1 comment
Assignees

Comments

@imagejan
Copy link
Member

imagejan commented May 6, 2024

In cases where, we acquire two channels within the same "action", we should not expect new auto-focus values in the TRACE log file.

2024/04/05,21:42:14,.466,300685296,Measurement,Measurement.measure_timelapse,_m_Timelapse,_action_acquire_3d_acq,z=436.8um,estimated_focus_value=0.00,cell=0
2024/04/05,21:42:14,.466,300685296,Measurement,Measurement.device_util,shift_z_pos
2024/04/05,21:42:14,.466,300685296,Portal,DeviceControlStatus,BeginPeriod,shift Z pos,Expected Time=16
2024/04/05,21:42:14,.466,300685296,Portal,RemoteDevice,ReaderControl,<---,AF_MANU,34,439.4,RC617
2024/04/05,21:42:14,.483,300685312,Portal,RemoteDevice,ReaderControl,--->,AF_MANU,34,0,OK,1030.2,0
2024/04/05,21:42:14,.484,300685312,Portal,DeviceControlStatus,EndPeriod,shift Z pos,actual time=17,difference=1
2024/04/05,21:42:14,.484,300685312,Measurement,Measurement.measure_timelapse,_m_Timelapse,_acquire_frame,Z=439um
2024/04/05,21:42:14,.489,300685312,Measurement,DCAMDevice,StartFileSave,DCAM:0,Y:\path\to\********.tif,0,NoOTFCorrection
2024/04/05,21:42:14,.489,300685312,Measurement,Measurement.measure_timelapse,_m_Timelapse,_init_frame_save,********.tif,None
2024/04/05,21:42:14,.489,300685312,Measurement,DCAMDevice,StartFileSave,DCAM:1,Y:\path\to\********.tif,0,NoOTFCorrection
2024/04/05,21:42:14,.489,300685312,Measurement,Measurement.measure_timelapse,_m_Timelapse,_init_frame_save,********.tif,None
2024/04/05,21:42:14,.489,300685312,Portal,DeviceControlStatus,BeginPeriod,acquire frames,Expected Time=250
2024/04/05,21:42:14,.489,300685312,Measurement,Measurement.device_camera,fire_multiple_triggers
2024/04/05,21:42:14,.667,300685484,Measurement,DCAMDevice,StopFileSave,DCAM:0
2024/04/05,21:42:14,.667,300685484,Measurement,Measurement.measure_timelapse,_m_Timelapse,_exit_frame_save
2024/04/05,21:42:14,.672,300685500,Measurement,DCAMDevice,StopFileSave,DCAM:1
2024/04/05,21:42:14,.672,300685500,Measurement,Measurement.measure_timelapse,_m_Timelapse,_exit_frame_save
2024/04/05,21:42:14,.672,300685500,Portal,DeviceControlStatus,EndPeriod,acquire frames,actual time=182,difference=-68

There's various possible strategies to solve this:

  • Don't reset the focus value, but simply take the last present one.
    • This might be error prone as we might assign wrong z values to images
  • Strip the C0*.tif part from the filename, and create a mapping with the remaining part of the name only
    • This will require additional logic when merging the z positions with the files table
    • We still parse both filenames, so we have to decide whether we want to issue a false warning, or add logic to ignore subsequent images with the same partial filename
  • Reset the Z value only at the beginning of a new "period", adding a new parsing step for BeginPeriod, assigning all images before that the same Z value

I prefer the last option, as it is minimal implementation effort, and (despite the additional parsed line) seems the "cleanest" approach.

@imagejan imagejan self-assigned this May 6, 2024
@imagejan
Copy link
Member Author

imagejan commented Jun 3, 2024

This was fixed with #128 and improved #138.

@imagejan imagejan closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant