From 8ed387e7af3984f9512e4079154703d103db9337 Mon Sep 17 00:00:00 2001 From: Ketan Umare Date: Tue, 9 Jun 2020 22:17:18 -0700 Subject: [PATCH 1/2] Metrics for redis --- kustomize/base/propeller/metrics.yaml | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 kustomize/base/propeller/metrics.yaml diff --git a/kustomize/base/propeller/metrics.yaml b/kustomize/base/propeller/metrics.yaml new file mode 100644 index 0000000000..b7fbc4f535 --- /dev/null +++ b/kustomize/base/propeller/metrics.yaml @@ -0,0 +1,28 @@ +apiVersion: extensions/v1beta1 +kind: Deployment +metadata: + namespace: flyte + name: redis-exporter +spec: + replicas: 1 + template: + metadata: + annotations: + prometheus.io/scrape: "true" + prometheus.io/port: "9121" + labels: + app: redis-exporter + spec: + containers: + # Ideally we would like this to be a sidecar with propeller, but scraping metrics is a hassle + # One option could be to import the exporter into propeller and run it from there. We can explore this if it provides value, lets test it first + # More configuration refer to https://github.com/oliver006/redis_exporter + - name: redis-exporter + image: docker.io/bitnami/redis-exporter + args: [ "-redis.addr=redis-resource-manager.flyte", "-redis.password=mypassword"] + resources: + requests: + cpu: 500m + memory: 200Mi + ports: + - containerPort: 9121 From e4290a12290349c3335d961eff585bd85c919bcd Mon Sep 17 00:00:00 2001 From: Ketan Umare Date: Tue, 9 Jun 2020 22:20:26 -0700 Subject: [PATCH 2/2] template link --- kustomize/base/propeller/metrics.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/kustomize/base/propeller/metrics.yaml b/kustomize/base/propeller/metrics.yaml index b7fbc4f535..7eb1635244 100644 --- a/kustomize/base/propeller/metrics.yaml +++ b/kustomize/base/propeller/metrics.yaml @@ -17,6 +17,7 @@ spec: # Ideally we would like this to be a sidecar with propeller, but scraping metrics is a hassle # One option could be to import the exporter into propeller and run it from there. We can explore this if it provides value, lets test it first # More configuration refer to https://github.com/oliver006/redis_exporter + # Also dashboard template - https://grafana.com/grafana/dashboards/763 - name: redis-exporter image: docker.io/bitnami/redis-exporter args: [ "-redis.addr=redis-resource-manager.flyte", "-redis.password=mypassword"]