Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] IDL docs: Specify array job parallelism is a max, not a min #3933

Closed
2 tasks done
katrogan opened this issue Aug 8, 2023 · 0 comments · Fixed by flyteorg/flyteidl#431
Closed
2 tasks done

[Docs] IDL docs: Specify array job parallelism is a max, not a min #3933

katrogan opened this issue Aug 8, 2023 · 0 comments · Fixed by flyteorg/flyteidl#431
Labels
documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers

Comments

@katrogan
Copy link
Contributor

katrogan commented Aug 8, 2023

Description

https://github.com/flyteorg/flyteidl/blob/b0c083121c310f088cc41fa111ba318bff20c83e/protos/flyteidl/plugins/array_job.proto#L13

implies that the parallelism field for array jobs is a min

however plugins code reads the field as a max:
https://github.com/flyteorg/flyteplugins/blob/c528bb88937b4732c9cb5537ed8ea6943ff4fb56/go/tasks/plugins/array/k8s/management.go#L145

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Aug 8, 2023
@katrogan katrogan mentioned this issue Aug 8, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct comment for array job max parallelism flyteorg/flyteidl
1 participant
@katrogan