Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align references to Secrets within all Source APIs #1131

Closed
aryan9600 opened this issue Jun 26, 2023 · 0 comments · Fixed by #1160
Closed

Align references to Secrets within all Source APIs #1131

aryan9600 opened this issue Jun 26, 2023 · 0 comments · Fixed by #1160
Labels
area/helm Helm related issues and pull requests enhancement New feature or request

Comments

@aryan9600
Copy link
Member

Historically all Source APIs used a single monolithic Secret for all sorts of configuration. But this is no longer true since there are Sources that have multiple Secret refs, for e.g.OCIRepository with its .spec.secretRef for auth credentials and .spec.certSecretRef for TLS certificates. Thus, to align how all Sources deal with Secrets, we need to make sure that all Source APIs drop the usage of monolithic Secrets and incorporate multiple Secret refs to configure different things.

Atm, only HelmRepository needs to be aligned with the new standard. This shall be done by adding a new field .spec.certSecretRef which would specify the Secret containing the TLS authentication data and deprecating support for the certFile, keyFile, caFile keys in the Secret specified in .spec.secretRef. Support for these keys will be fully removed when HelmRepository graduates to v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant