Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain types of notification not sent #165

Closed
Eadinator opened this issue Mar 19, 2021 · 1 comment · Fixed by #169
Closed

Certain types of notification not sent #165

Eadinator opened this issue Mar 19, 2021 · 1 comment · Fixed by #169
Assignees
Labels
area/alerting Alerting related issues and PRs bug Something isn't working

Comments

@Eadinator
Copy link

Flux version: 0.10.0
Provider: googlechat

Notifications for resources marked for deletion/deleted are sent to Google chat.
Notifications for resources created and health check notifications (as in https://toolkit.fluxcd.io/_files/slack-info-alert.png) are logged as dispatched by notification-controller but do not get sent to Google chat.

I think after a look at the code, this is because these events are incorrectly sent as "Progressing" events by kustomize-controller, and the notifier in notification-controller skips these events.

I think that events logged as dispatched by the notification-controller but which are black-holed by the notifier can be misleading, because they are not dispatched to the provider which it could be interpreted as.

@stefanprodan stefanprodan transferred this issue from fluxcd/flux2 Mar 19, 2021
@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs bug Something isn't working labels Mar 19, 2021
@somtochiama
Copy link
Member

Taking a look at this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants