Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webex as an Alert Provider #133

Closed
gdoctor opened this issue Jan 27, 2021 · 10 comments · Fixed by #168
Closed

Add Webex as an Alert Provider #133

gdoctor opened this issue Jan 27, 2021 · 10 comments · Fixed by #168

Comments

@gdoctor
Copy link
Contributor

gdoctor commented Jan 27, 2021

I am happy to implement this myself based off the existing providers and open a PR if members of this community are okay with that.

@stefanprodan
Copy link
Member

I thought Webex is like Zoom, video meetings only. Does it have chat channels like Slack?

@gdoctor
Copy link
Contributor Author

gdoctor commented Jan 27, 2021

Webex has a full chat client component that was called Webex Teams up until recently. I think they just brought it into the Webex suite and now it is being branded as Webex for messaging; it is essentially a chat client similar to Slack. For reference: https://www.webex.com/team-collaboration.html

Edit: I was thinking of using this plugin to implement the feature in a simple manner. The generic alert provider does not work simply because it does not populate the text field required by this plugin. - https://apphub.webex.com/messaging/applications/incoming-webhooks-cisco-systems-38054

@phillebaba
Copy link
Member

The only issue I see with implementing this feature would be testing and debugging issues.

@gdoctor
Copy link
Contributor Author

gdoctor commented Feb 10, 2021

I understand your concerns, but Webex has free tier accounts that should have complete access to the messaging components just like MSTeams. I am happy to implement and test and attach all pertinent screenshots.

@gdoctor
Copy link
Contributor Author

gdoctor commented Feb 26, 2021

I added support for Webex on my end, and I am using the image for my notification-controller deployment currently. Before I open a PR here. I want to make sure the flux developers are okay with the content of the message and formatting of it. I initially wanted to use an Adaptive Card like the MSTeams integration, but Webex does not support Adaptive Cards via the Incoming Webhook integration yet so I am left with markdown options. Also, I couldn't get json to look very good on webex.

The screenshot is directly from the Webex client. Let me know what you think @stefanprodan @phillebaba

image

@gdoctor
Copy link
Contributor Author

gdoctor commented Feb 26, 2021

This is what the full json looks like. The user scrolls to the right to see the rest of the message.

Screen Shot 2021-02-25 at 4 06 08 PM

@phillebaba
Copy link
Member

Just so that I understand the screenshots correctly, will the user see the formatted text or the JSON? I think that even if Webex is not totally identical to the other providers it should use the same format in the messages.

@gdoctor
Copy link
Contributor Author

gdoctor commented Mar 1, 2021

Sorry my messages were not clear. I provided 2 separate options for what the user could see. The first one is a format that I thought would be good. The second is what the user would see if I instead sent json. I prefer the first option.

@gdoctor
Copy link
Contributor Author

gdoctor commented Mar 1, 2021

Screen Shot 2021-03-01 at 11 41 08 AM

This screenshot is an updated version of the first option that also includes the metadata, which other providers were supplying.

@phillebaba
Copy link
Member

Considering the limitations of webex I think this formatting should be fine. Go ahead and create a PR and I will review it. Thanks for the hard work 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants