From 441b48aeef07a83d6aa3b87ca29012d1fa91dcf5 Mon Sep 17 00:00:00 2001 From: Kingdon Barrett Date: Thu, 13 Jan 2022 19:44:10 -0500 Subject: [PATCH] Use patch instead of update when adding finalizers Signed-off-by: Kingdon Barrett --- controllers/kustomization_controller.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/controllers/kustomization_controller.go b/controllers/kustomization_controller.go index b8766cfe..56c3974c 100644 --- a/controllers/kustomization_controller.go +++ b/controllers/kustomization_controller.go @@ -153,8 +153,9 @@ func (r *KustomizationReconciler) Reconcile(ctx context.Context, req ctrl.Reques // Add our finalizer if it does not exist if !controllerutil.ContainsFinalizer(&kustomization, kustomizev1.KustomizationFinalizer) { + patch := client.MergeFrom(kustomization.DeepCopy()) controllerutil.AddFinalizer(&kustomization, kustomizev1.KustomizationFinalizer) - if err := r.Update(ctx, &kustomization); err != nil { + if err := r.Patch(ctx, &kustomization, patch); err != nil { log.Error(err, "unable to register finalizer") return ctrl.Result{}, err }