Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example controller to new unified standards #1625

Open
scottrigby opened this issue Jul 14, 2021 · 1 comment
Open

Update Example controller to new unified standards #1625

scottrigby opened this issue Jul 14, 2021 · 1 comment

Comments

@scottrigby
Copy link
Member

scottrigby commented Jul 14, 2021

We already have an example controller that consumes the GitOps Toolkit Source APIs fluxcd/source-watcher. This accompanies the Watching for source changes Flux guide.

The example is however out of date with the new Flux controller standards that are currently in the process of being rolled out (#1601).

We need to make the example controller more complex, to help people understand how to use pkg/runtime. Must contain in-code documentation. This is a pre-step for updating the guide.

@scottrigby
Copy link
Member Author

scottrigby commented Jul 26, 2021

@stefanprodan suggests that we keep source-watcher as-is, because there is value in this as an example for IoT.

Thoughts on the new example:

  • should not also be a Flux specialized applier / delivery controller
  • example creates configmap from .env file
  • something easy that no one will use in production (for example k8s already has a configmap generator that does this)
  • maybe something like Ellen Korbes' fun "useless operator" (sets active/inactive lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant