Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Prevent CRD deletion on helm delete #1543

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Conversation

sfrique
Copy link
Contributor

@sfrique sfrique commented Nov 22, 2018

Hello,

If CRD were created by helm, once you delete flux, it would delete the CRD, this would cause flux to try to delete the charts while it's been terminated.

This PR makes helm do not remove CRD.

$ helm delete --purge flux
These resources were kept due to the resource policy:
[CustomResourceDefinition] fluxhelmreleases.helm.integrations.flux.weave.works
[CustomResourceDefinition] helmreleases.flux.weave.works

release "flux" deleted

I've also bumped the chart.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sfrique

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants