Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc14: render examples inline #145

Closed
garlick opened this issue Jan 9, 2019 · 4 comments
Closed

rfc14: render examples inline #145

garlick opened this issue Jan 9, 2019 · 4 comments

Comments

@garlick
Copy link
Member

garlick commented Jan 9, 2019

RFC 14 is kind of long and difficult to digest. It might be nice to refocus RFC 14 on succinctly defining well formed jobspec, leaving the examples and any expository discussion to another RFC.

Could we split the examples out to another Flux Jobspec Use Cases RFC? At the same time could we work around the fact that the jobspec examples are not rendered inline by github, by generating the final document with expanded examples as suggested in asciidoctor/asciidoctor#1088?

Edit: let's just focus on that last bit, rendering examples inline, here, and then we'll decide whether to open a new issue on reorganizing after that's done.

@grondo
Copy link
Contributor

grondo commented Jan 9, 2019

I'm not sure that splitting the material is going to make the RFC any easier to digest, it is just a difficult specification to grok (for me anyway). This might be a bit like trying to make Ulysses easier to understand by turning it into a trilogy. (besides, the rfc is < 1000 lines even with the examples) Maybe what we need is a rewrite?

However, I don't mind splitting up the use cases into a separate RFC, this does mean that updates to RFC 14 will always have to affect another RFC (and possibly vice versa).

At the same time could we work around the fact that the jobspec examples are not rendered inline by github, by generating the final document with expanded examples as suggested in github/markup#1088?

Did you reference the right issue/PR? That one is just a PR to integrate Asciidoctor 1.5.6.1 into github-markup and push it to github.com.

@garlick
Copy link
Member Author

garlick commented Jan 9, 2019

Did you reference the right issue/PR?

Referenced the wrong project! I edited the orig comment to reference the correct one.

@garlick
Copy link
Member Author

garlick commented Jan 10, 2019

Let's focus this issue on rendering examples inline in RFC 14. We can consider splitting it separately after we get this done.

@garlick garlick changed the title rfc14: split examples off to another RFC rfc14: render examples inline Jan 10, 2019
@garlick
Copy link
Member Author

garlick commented Mar 19, 2019

As discussed briefly in flux-framework/flux-core#2036, it sounds like we might pursue a way to publish our docs as static web pages. In pr #173 the make html target was updated to use asciidoctor and coderay to generate html that properly expands includes (and syntax highlights code examples). We just need somewhere to push them.

Given this direction, the workaround here of generating the adoc files is perhaps less interesting, so closing this issue.

@garlick garlick closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants