This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Enforce clang-format for c-like sources on Travis #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM for Obj-C world with same caveats as on #4088. |
fcc92d6 to
95c2cf5
Compare
cbracken
reviewed
Sep 11, 2017
CONTRIBUTING.md
Outdated
| [design principles](https://flutter.io/design-principles/) before | ||
| working on anything non-trivial. These guidelines are intended to | ||
| keep the code consistent and avoid common pitfalls. | ||
| * C, C++, and Objective-C code has to be formatted with `clang-format` before |
There was a problem hiding this comment.
uber-nit: should be or must be.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require #4088 to be submitted before travis is happy.