From 5aaa37a0566e0cd9c3bc20bae8b02c0838c2771f Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Tue, 8 Mar 2022 10:58:53 -0800 Subject: [PATCH 1/2] Fix bug with release notes viewer --- .../lib/src/shared/release_notes/release_notes.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/shared/release_notes/release_notes.dart b/packages/devtools_app/lib/src/shared/release_notes/release_notes.dart index 106164170f8..b06e95618ba 100644 --- a/packages/devtools_app/lib/src/shared/release_notes/release_notes.dart +++ b/packages/devtools_app/lib/src/shared/release_notes/release_notes.dart @@ -222,6 +222,8 @@ class ReleaseNotesController { } Future _fetchReleaseNotes(SemanticVersion version) async { + final currentVersionString = version.toString(); + // Try all patch versions for this major.minor combination until we find // release notes (e.g. 2.11.4 -> 2.11.3 -> 2.11.2 -> ...). var attempts = version.patch; @@ -243,7 +245,7 @@ class ReleaseNotesController { _releaseNotesMarkdown.value = releaseNotesMarkdown; toggleReleaseNotesVisible(true); unawaited( - server.setLastShownReleaseNotesVersion(versionString), + server.setLastShownReleaseNotesVersion(currentVersionString), ); return; } catch (_) { From 2a4b0bf93025fbbcc50d8911631efa1283ce2a4b Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Tue, 8 Mar 2022 11:00:04 -0800 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9fac0a28565..a49022b2328 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ ## 2.11.4 +* Fix bug with release notes viewer [#3811](https://github.com/flutter/devtools/pull/3811) * Try downgraded patch versions until we find release notes [#3809](https://github.com/flutter/devtools/pull/3809) * Fix null assertion in profile mode [#3808](https://github.com/flutter/devtools/pull/3808)