Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning on the inspector page if canvas measureString returns 0 #777

Closed
DanTup opened this issue Jul 9, 2019 · 1 comment
Closed
Labels
P3 issues we think are valid but not important reproduce to verify Issues that need to be reproduced to verify that they still exist. screen: inspector
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Jul 9, 2019

See discussion at #367 (comment)

The reason the inspector page is messed up in Brave (which otherwise looks like Chrome) is that it returns 0 from measureString as an anti-fingerprint mechanism. This is trivial to detect, so we should show a warning at the top of the page in this case telling the user that the trees may not render correctly because of this (it might not be Brave, it could be privacy extensions in Chrome too, but probably users with these would know what they're running if we give them an idea of the cause).

@kenzieschmoll kenzieschmoll added this to the Backlog milestone Jul 22, 2019
@kenzieschmoll kenzieschmoll added screen: inspector P3 issues we think are valid but not important reproduce to verify Issues that need to be reproduced to verify that they still exist. labels Oct 24, 2024
@elliette
Copy link
Member

Just tried using the Inspector from Brave and not seeing any strange formatting so closing this.

@elliette elliette closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 issues we think are valid but not important reproduce to verify Issues that need to be reproduced to verify that they still exist. screen: inspector
Projects
None yet
Development

No branches or pull requests

3 participants