Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support netstandard library instead of portable #105

Closed
lvermeulen opened this issue Sep 11, 2016 · 2 comments
Closed

Support netstandard library instead of portable #105

lvermeulen opened this issue Sep 11, 2016 · 2 comments

Comments

@lvermeulen
Copy link

Since netstandard 1.x is the next generation of portable, I am submitting a PR that gets rid of the Library/PortableLibrary and organizes the project into the typical netcore src/test folders. Targets are net45 and netstandard 1.3 (which gives you net46).

Here's the pull request

@tallesl
Copy link
Contributor

tallesl commented Oct 31, 2016

I updated the project to support netstandard 1.4 instead (f4d608a), Visual Studio offers a handy way to do that:

I ended up deciding not to merge your pr, I'm sorry about that.
There's a lot going on there (over 2000 lines changes on 98 files) and some things I'm not quite fond of (like build scripts or how you changed the root directories).

Next time try to discuss the issue before doing the pr and making the pr small as possible, I hope you understand why I'm not merging it.

@tallesl
Copy link
Contributor

tallesl commented Nov 5, 2016

Published on version 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants